search

apsun / NekoSMS

A pattern-based text message blocker for Android.
GNU General Public License v3.0
417 stars 44 forks source link

Add support for pattern test, five digit number whitelist #63

Closed Greyh4t closed 4 years ago

Greyh4t commented 4 years ago
  1. add new function that you can paste SMS to test the pattern when edit
  2. Add a 5-digit number whitelist switch, in china, most 5-digit number from public institutions like bank and so on
apsun commented 4 years ago

Thank you, the testing feature looks super useful, I'll review it once I get some time! However, I don't agree with having a built in feature for whitelisting 5 digit numbers. Reasons:

  1. You can already do it with a simple regex: ^.{5}$ or wildcard: ?????
  2. 5 digit numbers are exactly the ones that I want to block (fun fact, those stupid 10086/10000 daily text messages are the entire reason this app even exists). If there's an option to whitelist them, why isn't there an option to blacklist them? It opens up a can of worms as to what we should natively support and what should just be a user-made rule. I added a contact whitelist because there's no way to express it with one rule, and that hopefully nobody would want to ever block their contacts.
Greyh4t commented 4 years ago

Yes, you are right, I did not consider this, I will remove the 5 digit numbers whitelist function later.