search

apsun / NekoSMS

A pattern-based text message blocker for Android.
GNU General Public License v3.0
417 stars 44 forks source link

Support android 12 #83

Closed NekoGirlSAIKOU closed 2 years ago

apsun commented 2 years ago

This is awesome - thanks so much for this! I have some minor questions about the android:exported changes, but overall looks good to me!

nijel8 commented 2 years ago

Great to see Android 12 support is on the way. Thank you both! Maybe not the right place, please excuse me... I just installed current release on Android 12 with LSPosed, off course hooking dispatchIntent() not working as expected method not found, but what bothers me is NekoSMS doesn't detect LSPosed Xposed framework implementation and shows dialogue Xposed not installed although module loads and tries to hook dispatchIntent(). Thank you again!

apsun commented 2 years ago

Great to see Android 12 support is on the way. Thank you both! Maybe not the right place, please excuse me... I just installed current release on Android 12 with LSPosed, off course hooking dispatchIntent() not working as expected method not found, but what bothers me is NekoSMS doesn't detect LSPosed Xposed framework implementation and shows dialogue Xposed not installed although module loads and tries to hook dispatchIntent(). Thank you again!

You need to configure LSposed to hook the NekoSMS package (com.crossbowffs.nekosms), see https://github.com/apsun/NekoSMS/issues/74. If you have questions, please file a new issue (https://github.com/apsun/NekoSMS/issues), thanks!

nijel8 commented 2 years ago

Great to see Android 12 support is on the way. Thank you both! Maybe not the right place, please excuse me... I just installed current release on Android 12 with LSPosed, off course hooking dispatchIntent() not working as expected method not found, but what bothers me is NekoSMS doesn't detect LSPosed Xposed framework implementation and shows dialogue Xposed not installed although module loads and tries to hook dispatchIntent(). Thank you again!

You need to configure LSposed to hook the NekoSMS package (com.crossbowffs.nekosms), see #74. If you have questions, please file a new issue (https://github.com/apsun/NekoSMS/issues), thanks!

Actually the issue is isXposedInstalled() method. There is no more Xposed package present on Android 9+ systems with no official Xposed Bridge support. Newer Android versions use LSPosed, Edxposed etc. Xposed implementations as Magisk modules so check fails and Module not active/Xposed not installed dialog shows although the module works...

apsun commented 2 years ago

Great to see Android 12 support is on the way. Thank you both! Maybe not the right place, please excuse me... I just installed current release on Android 12 with LSPosed, off course hooking dispatchIntent() not working as expected method not found, but what bothers me is NekoSMS doesn't detect LSPosed Xposed framework implementation and shows dialogue Xposed not installed although module loads and tries to hook dispatchIntent(). Thank you again!

You need to configure LSposed to hook the NekoSMS package (com.crossbowffs.nekosms), see #74. If you have questions, please file a new issue (https://github.com/apsun/NekoSMS/issues), thanks!

Actually the issue is isXposedInstalled() method. There is no more Xposed package present on Android 9+ systems with no official Xposed Bridge support. Newer Android versions use LSPosed, Edxposed etc. Xposed implementations as Magisk modules so check fails and Module not active/Xposed not installed dialog shows although the module works...

If you configured the hook correctly, isXposedInstalled() never gets called in the first place - please read the issue I linked, and create a new issue if you're still having problems afterwards. Please don't comment in this PR since it's an unrelated issue - thanks.

NekoGirlSAIKOU commented 2 years ago

The FilterEditorActivity is no longer exported.