search

apsun / TumblrAdAway

A simple ad-blocker for the Android Tumblr app.
MIT License
26 stars 3 forks source link

Not working on Xposed Tumblr 5.6.x #2

Closed ChesterHCopperpot closed 8 years ago

ChesterHCopperpot commented 8 years ago

Any updates to this?

apsun commented 8 years ago

I actually haven't received the update yet (I'm still on 5.5). I'll let you know when Google Play decides to push it out to my phone.

apsun commented 8 years ago

I've updated to 5.6.1, and it seems to work fine. Can you post a logcat output?

adb logcat -s "TumblrAdAway"

ChesterHCopperpot commented 8 years ago

It isn't showing up yet in my Xposed updates. I'll let you know when it does.

On Tue, Mar 22, 2016 at 11:26 AM, Andrew Sun notifications@github.com wrote:

I've updated to 5.6.1, and it seems to work fine. Can you post a logcat output?

adb logcat -s "TumblrAdAway"

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/apsun/TumblrAdAway/issues/2#issuecomment-199864465

apsun commented 8 years ago

Oh, I meant the Tumblr app, I haven't updated the Xposed module in a while now (because the way ads are loaded hasn't changed since 5.1.0).

ChesterHCopperpot commented 8 years ago

Oh ok. I'm running Xposed on 5.6.x and the ads are showing up, but maybe I'm doing something wrong.

On Tue, Mar 22, 2016 at 12:10 PM, Andrew Sun notifications@github.com wrote:

Oh, I meant the Tumblr app, I haven't updated the Xposed module in a while now (because the way ads are loaded hasn't changed since 5.1.0).

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/apsun/TumblrAdAway/issues/2#issuecomment-199884698

apsun commented 8 years ago

It's working fine on my end, so I can't diagnose the problem without any logs. Could you post your Xposed logs? (Xposed Installer -> Logs -> Menu -> Send/Save to SD card)

ChesterHCopperpot commented 8 years ago

Attached On Mar 22, 2016 12:38 PM, "Andrew Sun" notifications@github.com wrote:

It's working fine on my end, so I can't diagnose the problem without any logs. Could you post your Xposed logs? (Xposed Installer -> Logs -> Menu -> Send/Save to SD card)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/apsun/TumblrAdAway/issues/2#issuecomment-199894376

apsun commented 8 years ago

Hmm, I can't see it, I guess email reply doesn't handle attachments... Could you paste it as a code block using the website instead?

apsun commented 8 years ago

Hmm, it seems that Xposed is not even trying to load TumblrAdAway. Are you sure it's enabled? Try reinstalling it, just in case.

ChesterHCopperpot commented 8 years ago

Ack! Wow. I'm dumb. :)

On Tue, Mar 22, 2016 at 1:46 PM, Andrew Sun notifications@github.com wrote:

Hmm, it seems that Xposed is not even trying to load TumblrAdAway. Are you sure it's enabled? Try reinstalling it, just in case.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/apsun/TumblrAdAway/issues/2#issuecomment-199931997

apsun commented 8 years ago

Haha, I presume everything is working as expected then? ;-)

ChesterHCopperpot commented 8 years ago

Yes :)

On Tue, Mar 22, 2016 at 1:52 PM, Andrew Sun notifications@github.com wrote:

Haha, I presume everything is working as expected then? ;-)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/apsun/TumblrAdAway/issues/2#issuecomment-199936261