search

aptabase / aptabase-maui

MAUI SDK for Aptabase: Open Source, Privacy-First and Simple Analytics for Mobile, Desktop and Web Apps
https://aptabase.com
MIT License
10 stars 6 forks source link

DO NOT MERGE: Adds an IsDebug flat to InitOptions #2

Closed joshball closed 6 months ago

joshball commented 8 months ago

Note: MAUI and VS just had an update, and as usual, this breaks all my projects builds. So, I cannot build this project presently (ResolveTargetingPackAssets tasks failed). Things will likely fix magically as reboots happen. So feel free to pull this down and check it yourself, or it may be a few days before I can vouch for the code.

The InitOptions now has an IsDebug option that can be set. This overrides what the SystemInfo object attempts to determine (which currently does not work).

Future work would be to replace Assembly.GetEntryAssembly (which returns null) with Assembly.GetExecutingAssembly (which will correctly return the assembly). That change is not in this PR.

goenning commented 8 months ago

Should we not make IsDebug optional on the InitOptions?

otherwise there’s no way for us to know if the user has defined a value or not

cristipufu commented 6 months ago

Fixed by 494f7d5831440437e621b1b3b93c302c674d393d