search

aptabase / aptabase-swift

Swift SDK for Aptabase: Open Source, Privacy-First and Simple Analytics for Mobile, Desktop and Web Apps
https://aptabase.com
MIT License
21 stars 8 forks source link

Detect macOS Catalyst #8

Closed manucheri closed 11 months ago

manucheri commented 11 months ago

Currently if the app is run on macOS as a Catalyst app (basically the iOS, i.e. UIKit instead of AppKit, version adapted to work on macOS) it is reported as iOS.

While this might be (at least somewhat) true in some technical sense, I feel that counting it as running on macOS better captures what is actually going on.

goenning commented 11 months ago

Thanks @manucheri the PR looks good to me.

I'd personally prefer to have macOS instead of macOS (Catalyst). I think in future we could expand the model to have more fields where Catalyst would fit better.

manucheri commented 11 months ago

Thanks @manucheri the PR looks good to me.

I'd personally prefer to have macOS instead of macOS (Catalyst). I think in future we could expand the model to have more fields where Catalyst would fit better.

Changed to report the OS name as macOS.

goenning commented 11 months ago

Looks great, thank you! will release new patch version now