search

aptana / studio3

This repository contains the code for core components of Aptana Studio 3.
http://aptana.com/products/studio3
Other
1.08k stars 484 forks source link

TISTUD-8703 Error reporting: NPE after launching the Studio #413

Closed kolipakakondal closed 7 years ago

kolipakakondal commented 7 years ago

NPE is at :https://github.com/appcelerator/titanium_studio/blob/694eaa3db28ea34dc4d3138dc82a8748a9808c3e/plugins/com.appcelerator.titanium.core/src/com/appcelerator/titanium/core/internal/cli/NodeAppcCLI.java#L769

It was caused by InterruptedException at https://github.com/aptana/studio3/blob/61328452f22122753ebbed313cb5a14d9293e976/plugins/com.aptana.core/src/com/aptana/core/util/ProcessRunner.java#L403

so the solution is to, send the original status of the process execution so that callers will know the cause and handle them the way it's required - whether it's reporting to the user, log it or ignoring.

kolipakakondal commented 7 years ago

@ppedduri - PR is ready for review

ssekhri commented 7 years ago

FR Passed. No error reported on studio launch @kolipakakondal Can you kindly merge this PR.