search

aptana / studio3

This repository contains the code for core components of Aptana Studio 3.
http://aptana.com/products/studio3
Other
1.07k stars 483 forks source link

Initial changes for eclipse-oxygen (4.7) migration. #447

Closed ppedduri closed 6 years ago

ppedduri commented 6 years ago

This PR is a placeholder for managing all changes related to eclipse-oxygen (4.7) migration. The first commit addresses all issues except for reporting plugin (aeri.ui).

ppedduri commented 6 years ago

Build fails because, we have new dependency added (to address removal of certain plugins within eclipse 4.7). More details here: http://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fporting%2Fremovals.html&cp=2_3_0

kolipakakondal commented 6 years ago

A couple of other issues:

  1. IDEWorkbenchMessages.WorkbenchWindow_shellTitl still shows error - we can just replace with the actual text
  2. Project icons are shown in red color
ppedduri commented 6 years ago

IDEWorkbenchMessages.WorkbenchWindow_shellTitl still shows error - we can just replace the actual text -- This is done, my bad. I should have submitted a PR for this on titanium_studio repo. Project folders issue -- will check.

ppedduri commented 6 years ago

incorporated most of the review comments, except for the Policy.java class changes and pushed commit-2. A related titanium_studio PR is here: https://github.com/appcelerator/titanium_studio/pull/1042

ppedduri commented 6 years ago

Addressed Policy.java 's error handling methods. Removed these and started referring to eclipse implementation directly.

ppedduri commented 6 years ago

Thanks for addressing plugin load issue @kolipakakondal ! 👍

kolipakakondal commented 6 years ago

Merging eclipse integration changes so that we can work on the build issues directly