search

aptana / studio3

This repository contains the code for core components of Aptana Studio 3.
http://aptana.com/products/studio3
Other
1.07k stars 483 forks source link

TISTUD-7442 : Refactoring Studio <-> CLI communication w.r.t. sessions #470

Closed ppedduri closed 5 years ago

ppedduri commented 6 years ago

Ref: https://jira.appcelerator.org/browse/TISTUD-7442 & https://jira.appcelerator.org/browse/CLI-1065

Introduced new enum to match Error codes returned by CLI (Ref CLI-1065) Started adopting to the Error messages in various scenarios where Studio used to throw the user a question dialog (for credentials) each time there is a session expiry/invalidation. Addressed multiple scenarios which make use of a user session. Let us update this PR with all observations and suggestions to improve this further.

ppedduri commented 6 years ago

@kolipakakondal Thanks for the review. Incorporated your comments. Please review.

ppedduri commented 6 years ago

@kolipakakondal , I have modified the error messages to indicate login method to the user. It's a minor change. Kindly review again.