aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

Fix Windows exit tunnel #214

Closed krallin closed 7 years ago

krallin commented 7 years ago

It looks like we need to apply more force when shutting down OpenSSH on Windows, at least when using the Windows fork (https://github.com/PowerShell/Win32-OpenSSH / https://github.com/PowerShell/openssh-portable).

Using SIGINT, it looks like the OpenSSH process doesn't do anything.

Unfortunately, it appears this causes OpenSSH to not cleanly disconnect from the server.

This is not ideal, but it's probably acceptable for now since we'll stop sending keep-alives and the connection should end up shutting down on the server-side reasonably quickly (about 2 minute later).


This should fix part of the issue reported in https://github.com/aptible/aptible-cli/issues/212

cc @fancyremarker

codecov-io commented 7 years ago

Current coverage is 89.90% (diff: 100%)

Merging #214 into master will decrease coverage by 0.01%

@@             master       #214   diff @@
==========================================
  Files            41         41          
  Lines          1349       1347     -2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1213       1211     -2   
  Misses          136        136          
  Partials          0          0          

Powered by Codecov. Last update 7d924f7...cdb0c6c