search

aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

Tunnel Helper: Force-kill after 5 seconds #218

Closed krallin closed 7 years ago

krallin commented 7 years ago

This adds support for force-killing the SSH Helper after 5 seconds if it doesn't exist immediately. This isn't required when running actual OpenSSH, but when running the mock ssh.bat helper we use in tests, it usually is (because sending SIGBRK, or even SIGINT to a console doesn't always reliably terminate it).

NOTE: I'm leaving around a couple debug helpers in specs if needed in the future.

cc @fancyremarker

codecov-io commented 7 years ago

Codecov Report

Merging #218 into master will increase coverage by -0.08%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   90.55%   90.47%   -0.08%     
==========================================
  Files          43       43              
  Lines        1440     1449       +9     
==========================================
+ Hits         1304     1311       +7     
- Misses        136      138       +2
Impacted Files Coverage Δ
lib/aptible/cli/helpers/tunnel.rb 94.54% <100%> (+0.42%) :white_check_mark:
spec/shared/mock_ssh_context.rb 77.77% <33.33%> (-8.89%) :x:
lib/aptible/cli/helpers/app.rb 100% <ø> (ø) :white_check_mark:
lib/aptible/cli/subcommands/logs.rb 100% <ø> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40900dc...86217a4. Read the comment docs.