search

aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

Explain tunnel timeouts #221

Closed krallin closed 7 years ago

krallin commented 7 years ago

We'll use exitcode 124 to indicate a timeout.

See: https://github.com/aptible/dynamic-uno/pull/12

cc @fancyremarker

krallin commented 7 years ago

It turns out that I had also broken tunnels in #218, which we fortunately never released (this would have been caught by the integration tests); that was never released, though, but it's another reason to merge this fix.

codecov-io commented 7 years ago

Codecov Report

Merging #221 into master will increase coverage by 0.01%. The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files          43       43              
  Lines        1449     1473      +24     
==========================================
+ Hits         1311     1333      +22     
- Misses        138      140       +2
Impacted Files Coverage Δ
spec/aptible/cli/helpers/tunnel_spec.rb 100% <100%> (ø) :arrow_up:
lib/aptible/cli/helpers/tunnel.rb 91.66% <75%> (-2.88%) :arrow_down:
lib/aptible/cli/subcommands/logs.rb 100% <0%> (ø) :arrow_up:
lib/aptible/cli/helpers/app.rb 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9480a28...536c945. Read the comment docs.