aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

Add a `aptible services` command #238

Closed krallin closed 7 years ago

krallin commented 7 years ago

This command lists services for an app, including their command and scale.


cc @fancyremarker @UserNotFound

Open question here: do we want to warn when there are no services for an app (because it was never deployed), or keep the output consistent? (this would probably be worth a more generic and concerted effort to update warnings throughout the CLI)

codecov-io commented 7 years ago

Codecov Report

Merging #238 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   95.58%   95.67%   +0.08%     
==========================================
  Files          56       58       +2     
  Lines        2717     2772      +55     
==========================================
+ Hits         2597     2652      +55     
  Misses        120      120
Impacted Files Coverage Δ
lib/aptible/cli/agent.rb 99.09% <100%> (+0.01%) :arrow_up:
spec/aptible/cli/subcommands/services_spec.rb 100% <100%> (ø)
lib/aptible/cli/subcommands/services.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6526e19...dd6a785. Read the comment docs.

UserNotFound commented 7 years ago

I'm not terribly familiar with the CLI in this scenario (App created but not successfully deployed), so I'll research a bit for myself in this type of scenario to form an opinion.