Closed krallin closed 6 years ago
Merging #243 into master will increase coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 96.84% 96.91% +0.07%
==========================================
Files 80 81 +1
Lines 3332 3409 +77
==========================================
+ Hits 3227 3304 +77
Misses 105 105
Impacted Files | Coverage Δ | |
---|---|---|
spec/fabricators/operation_fabricator.rb | 100% <100%> (ø) |
:arrow_up: |
lib/aptible/cli/subcommands/db.rb | 91.44% <100%> (+1.37%) |
:arrow_up: |
spec/fabricators/database_image_fabricator.rb | 100% <100%> (ø) |
|
lib/aptible/cli/helpers/database.rb | 77.21% <100%> (+2.92%) |
:arrow_up: |
spec/aptible/cli/subcommands/db_spec.rb | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 51cfcf7...8a3861e. Read the comment docs.
One question I'm wondering about is whether we should name the list command db:images
or db:versions
. I'm leaning towards db:versions
(since the parameter is called --version
in db:create
). What do you think @fancyremarker @UserNotFound ?
Thanks! Went with db:versions
.
This allows customers to specify a specific Database Image (i.e. version) when creating a new Database via the CLI.
The db:images command also allows listing available Database Images.
This builds upon #241, for the
db:images
command.See https://github.com/aptible/api.aptible.com/pull/582 for the backend changes
Post release, we should make sure to update the documentation for
db:create
to referencedb:images
.cc @fancyremarker @UserNotFound