search

aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

Do not colorize logs without a TTY #244

Closed krallin closed 6 years ago

krallin commented 6 years ago

We have at least one customer parsing the output of db:tunnel, and colorizing logs broke their integration, so let's fix this here.

(that said, we should probably consider better scriptability on db:tunnel, the output right now is not even formatted / available as JSON, and broadly speaking the command does not make it super easy to access it)

cc @fancyremarker

codecov-io commented 6 years ago

Codecov Report

Merging #244 into master will decrease coverage by 0.11%. The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #244      +/-   ##
=========================================
- Coverage   96.92%   96.8%   -0.12%     
=========================================
  Files          81      81              
  Lines        3410    3416       +6     
=========================================
+ Hits         3305    3307       +2     
- Misses        105     109       +4
Impacted Files Coverage Δ
spec/aptible/cli_spec.rb 100% <100%> (ø) :arrow_up:
lib/aptible/cli.rb 76.66% <37.5%> (-10.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41511d3...43b0395. Read the comment docs.