search

aptible / aptible-cli

Command line interface to Aptible
MIT License
28 stars 35 forks source link

deploy / config:set reject lonely strings #247

Closed krallin closed 6 years ago

krallin commented 6 years ago

aptible deploy foo is most likely a user error. If the user intends to unset the variable, they can always use aptible deploy foo=.

See: https://aptible.slack.com/archives/C02NMLZ8N/p1526050573000420

cc @fancyremarker @UserNotFound @almathew

codecov-io commented 6 years ago

Codecov Report

Merging #247 into master will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #247      +/-   ##
=========================================
+ Coverage    96.8%   96.9%   +0.09%     
=========================================
  Files          81      81              
  Lines        3416    3422       +6     
=========================================
+ Hits         3307    3316       +9     
+ Misses        109     106       -3
Impacted Files Coverage Δ
lib/aptible/cli/helpers/app.rb 100% <100%> (ø) :arrow_up:
spec/aptible/cli/subcommands/deploy_spec.rb 100% <100%> (ø) :arrow_up:
lib/aptible/cli/helpers/tunnel.rb 96.61% <0%> (+5.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c6ba2a...cd016bc. Read the comment docs.