search

aptible / dashboard.aptible.com

DEPRECATED - Ember.js dashboard for the Aptible PaaS
https://dashboard.aptible.com
MIT License
81 stars 35 forks source link

Some liquid fire improvements #718

Closed skylar-anderson closed 8 years ago

skylar-anderson commented 8 years ago

This PR updates the apps#create and databases#create route to actually be modal components.

Sadly @blakepettersson this removes the current list-databases component and the need for the new list-apps component as you no longer need to bubble up the forceRedirect action.

Further, this PR fixes the issue of a user lacking manage permissions on an environment being redirected to the new route for apps/databases. This is confusing as they can't actually create any new resources and they'd just get an error when attempting to create. This PR hides the create button for these users.

This also changes the UX for empty index pages. Rather than redirecting immediately to the new route, you now get a simple message with a button. Images below.

Empty Index UI

screenshot 2016-09-05 16 40 38

Create DB UI

screenshot 2016-09-05 16 40 22
skylar-anderson commented 8 years ago

I wrapped up this PR early in order to make it in time for Engineering Show & Tell, but ideally we'd use this same model on Log Drains and Certificates as well.

krallin commented 8 years ago

This PR hides the create button for these users.

Do you think we could show them a message explaining they don't have permission? In my experience just hiding the button when a user is missing permissions doesn't necessarily make it clear how they should go about resolving this problem.

skylar-anderson commented 8 years ago

@krallin - Yeah that's a good point. I'll change that behavior.