aptible / dashboard.aptible.com

DEPRECATED - Ember.js dashboard for the Aptible PaaS
https://dashboard.aptible.com
MIT License
81 stars 35 forks source link

Allow updating and deleting a failed Endpoint #769

Closed krallin closed 7 years ago

krallin commented 7 years ago

We need to allow updating failed Endpoints, because with ALBs customers must provide a certificate that's within its validity period, or it'll be rejected when we try to upload it into IAM.

It's probably also a good idea to let customers delete these Endpoints if they realize they've made a mistake (right now, you can't delete the Endpoint unless you first get it to succeed provisioning, which can be a little hard since we now require that the health check passes when provisioning the Endpoint).


cc @fancyremarker @sandersonet

fancyremarker commented 7 years ago

Big improvement, also for this reason you mentioned:

It's probably also a good idea to let customers delete these Endpoints if they realize they've made a mistake

LGTM, I figure @sandersonet will agree but leave it to him to comment on Ember details.