aptible / dashboard.aptible.com

DEPRECATED - Ember.js dashboard for the Aptible PaaS
https://dashboard.aptible.com
MIT License
81 stars 35 forks source link

New Endpoint: use service process type, not handle #781

Closed krallin closed 7 years ago

krallin commented 7 years ago

The handle for a service isn't ideal to let users differentiate between services, mainly because:

This is presumably why we don't use it anywhere in the UI (at least that I know of), except on the New Endpoint page. This can be a problem, because it means users sometimes can't tell which service is which.

This patch fixes the issue by instead using the process type and appending the command (so that it's shown if there is room), which should make it easier for users to interact with this.

I've also added tests to ensure this selector actually works (which was a little more involved than I anticipated, since the mocks here were being created in two different places).


cc @sandersonet, for review cc @fancyremarker, we talked about this last week: https://aptible-support.slack.com/archives/general/p1478811311000983