search

aptible / fridge

Token validation for distributed resource servers
MIT License
6 stars 7 forks source link

Support Ruby 3 #14

Closed almathew closed 1 year ago

almathew commented 2 years ago

Doing the minimum work required right now to avoid rampant dependency mismatches downstream.

I'm sure someday we'll regret my choice not to pin activesupport and nokogiri, but right now it's super convenient to let bundle resolve the correct version instead.

fancyremarker commented 2 years ago

@almathew : (same comment as aptible/aptible_api_shared#47) as discussed in Slack, I'm leaving this open until we can confirm deploy-api tests pass on the updated gem; perhaps open a deploy-api PR with gems pinned to branches and assign me to review it?

fancyremarker commented 2 years ago

@almathew : You may have already noted this, but your tests run against https://github.com/aptible/deploy-api/commit/91824057c87a74b0759f2e1f6f2648ca97aefc59 didn't pull in these changes. (A gem's "sub-gems" referenced in Gemfile are only respected in a local development/test context, not when the gem is pulled in by reference.) So, if you want to test that deploy-api works with these changes, you'd need to explicitly reference this branch in deploy-api's Gemfile too.

fancyremarker commented 2 years ago

@almathew : for when you're ready to release this, I invited you to be a gem owner.

almathew commented 2 years ago

I shared this in the aptible_api_shared repo, but downstream tests have been updated to use this version of fridge and are passing. Just waiting on approval @fancyremarker

almathew commented 1 year ago

I'm merging with @mdelaossa 's approval because all of @fancyremarker 's requested changes were met.