aptible / supercronic

Cron for containers
MIT License
1.91k stars 115 forks source link

space issue while exporting env var SUPERCRONIC_SHA1SUM #113

Closed lokeshrajai closed 1 year ago

lokeshrajai commented 2 years ago
Screenshot 2022-09-18 at 7 08 39 PM

the space in

SUPERCRONIC_SHA1SUM= d7f4c0886eb85249ad05ed592902fa6865bb9d70

causes issue while export env var

sha1sum: 'standard input': no properly formatted SHA1 checksum lines found

from the release page, installation instructions

https://github.com/aptible/supercronic/releases#:~:text=SUPERCRONIC_SHA1SUM%3D%20d7f4c0886eb85249ad05ed592902fa6865bb9d70

capelio commented 2 years ago

I was caught by this as well. It's a small thing, but it definitely breaks the installation flow when following all the official documentation and attempting to use the Dockerfile instructions from the latest release page.

bradgessler commented 1 year ago

Yeah I ran into this copy & pasting from the latest release notes https://github.com/aptible/supercronic/releases/tag/v0.2.1

My error was much less clear though, so it took me a while to chase this down.

Another suggestion I have for the release notes; you might consider adding a comment above each copy pasta block that reads like this:

# Latest releases available at https://github.com/aptible/supercronic/releases
ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.2.1/supercronic-linux-amd64 \
    SUPERCRONIC=supercronic-linux-amd64 \
    SUPERCRONIC_SHA1SUM=d7f4c0886eb85249ad05ed592902fa6865bb9d70

RUN curl -fsSLO "$SUPERCRONIC_URL" \
 && echo "${SUPERCRONIC_SHA1SUM}  ${SUPERCRONIC}" | sha1sum -c - \
 && chmod +x "$SUPERCRONIC" \
 && mv "$SUPERCRONIC" "/usr/local/bin/${SUPERCRONIC}" \
 && ln -s "/usr/local/bin/${SUPERCRONIC}" /usr/local/bin/supercronic

That will make it much easier for people in the Dockerfile to know exactly where to go for updates.

Thanks so much for superchronic! It's pretty great.

UserNotFound commented 1 year ago

Thanks everyone, the release notes have been updates to omit the space, and future release notes (such as this one) will include the note @bradgessler suggested.