search

aptible / supercronic

Cron for containers
MIT License
1.86k stars 113 forks source link

Allow to specify sentry envionment and release. #140

Closed imperiuse closed 10 months ago

imperiuse commented 10 months ago

Hi all! PR for this issue -> https://github.com/aptible/supercronic/issues/114

imperiuse commented 10 months ago

From what I can see, the tests failed due to a dependency in the Go standard library. They can be fixed by upgrading the Go version. However, I'm not sure if such changes should be made by me or implemented in the current PR.

Can someone clarify what guidelines exist regarding this?

imperiuse commented 10 months ago

Hey @imperiuse, thanks for the PR! Two things before merging:

  1. Can you merge in recent changes to master? I fixed the govulnreport build failure you've already noticed by upgrading the go version, that should make your build green.
  2. Can you update the README? There's a section describing the Sentry config already that should be updated with this PR.

Thanks!

done.

imperiuse commented 10 months ago

LGTM, thanks again!

Thank you for the review. Should I do anything else, or should I wait for the project maintainers? P.S. This PR is important to me, I would like to get it in the release as soon as possible. Thx!

aaw commented 10 months ago

@imperiuse I just merged this PR and released it as v0.2.28.