search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

Make m5 the default instance class #103

Closed aaw closed 12 months ago

aaw commented 1 year ago

If a terraform config doesn't explicitly provide a container profile for an app or database, we fill in m4. Since we're going to upgrade everyone to m5 starting a week from now, we need to default to m5 instead. Otherwise, after we upgrade everyone, a terraform config that doesn't explicitly provide a container profile will generate a plan to downgrade everything to m4.

Running this provider against your config before your apps and databases have been upgraded will just result in an early upgrade to m5 for apps and databases, which can be overridden by explicitly specifying m4 if the upgrade is unwanted.

This PR couples with https://github.com/aptible/go-deploy/pull/64, I've released that and bumped the version here with just go get github.com/aptible/go-deploy

aaw commented 12 months ago

https://app.shortcut.com/aptible/story/17597/support-m5-as-default

shortcut-integration[bot] commented 12 months ago

This pull request has been linked to Shortcut Story #17597: Support m5 as default.

aaw commented 12 months ago

@joshraker friendly ping for a review

aaw commented 12 months ago

Just one oddity in the go.sum. If you're up for a challenge you could update the profile validation to raise a warning, rather than an error so that the next time we add a profile users can use it without having to update their client right away.

Turns out the validations for instance profile are already warnings. I tested an example with a bogus instance profile anyway and saw terraform plan only give me a warning.