search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

Add aptible_environment.backup_retention_policy and data source #114

Closed joshraker closed 2 months ago

joshraker commented 3 months ago
joshraker commented 3 months ago

Acceptance tests passing

❯ make testacc TESTARGS='-run BackupRetentionPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 12 -timeout 30m -run BackupRetentionPolicy
...
--- PASS: TestAccDataSourceBackupRetentionPolicy_validation (0.28s)
--- PASS: TestAccResourceBackupRetentionPolicy_validation (0.90s)
--- PASS: TestAccResourceBackupRetentionPolicy_basic (3.40s)
--- PASS: TestAccDataSourceBackupRetentionPolicy_basic (4.74s)
--- PASS: TestAccResourceBackupRetentionPolicy_update (5.20s)
PASS
ok      github.com/aptible/terraform-provider-aptible/aptible   5.765s
joshraker commented 3 months ago

Consider reviewing the last commit separately since it's changes to unrelated docs:

joshraker commented 2 months ago

Acceptance tests passing after the move

❯ make testacc TESTARGS="-run 'TestAccResourceEnvironment|TestAccDataSourceBackupRetentionPolicy'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 12 -timeout 30m -run 'TestAccResourceEnvironment|TestAccDataSourceBackupRetentionPolicy'
...
--- PASS: TestAccDataSourceBackupRetentionPolicy_validation (1.01s)
--- PASS: TestAccResourceEnvironment_validation (1.42s)
--- PASS: TestAccDataSourceBackupRetentionPolicy_basic (3.87s)
--- PASS: TestAccResourceEnvironment_basic (4.20s)
--- PASS: TestAccResourceEnvironment_no_org (4.48s)
--- PASS: TestAccResourceEnvironment_backup_policy (4.48s)
--- PASS: TestAccResourceEnvironment_update (5.93s)
PASS
ok      github.com/aptible/terraform-provider-aptible/aptible   6.461s
joshraker commented 2 months ago

If multiple backup retention policies are specified, an error is raised before apply.

Screenshot 2024-07-02 at 16 19 53
joshraker commented 2 months ago 
❯ make testacc TESTARGS="-run 'TestAccResourceEnvironment|TestAccDataSourceBackupRetentionPolicy'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 12 -timeout 30m -run 'TestAccResourceEnvironment|TestAccDataSourceBackupRetentionPolicy'
...
--- PASS: TestAccDataSourceBackupRetentionPolicy_validation (0.46s)
--- PASS: TestAccResourceEnvironment_validation (0.92s)
--- PASS: TestAccResourceEnvironment_backup_policy (5.97s)
--- PASS: TestAccDataSourceBackupRetentionPolicy_basic (5.99s)
--- PASS: TestAccResourceEnvironment_basic (7.14s)
--- PASS: TestAccResourceEnvironment_no_org (7.26s)
--- PASS: TestAccResourceEnvironment_update (8.75s)
PASS
ok      github.com/aptible/terraform-provider-aptible/aptible   9.312s