Closed almathew closed 4 years ago
Updated to use the correct go-deploy commit now that those changes are squashed + merged
I didn't functionally change tests 😬
@almathew Just checking on this. I think an acceptance test here is needed. Do you want to merge this as is and I can open other PR with that? Or did you want to add here yourself?
I can grab the tests.
Ok, turns out I did miss something stupid (because of course I did). So this PR is now required: https://github.com/aptible/go-deploy/pull/20
Once that's merged, I'll update go.mod, but acceptance tests should pass.
Ok, tests only take a century to run, but they should finally be fixed, updated, and good to go:
PASS
ok github.com/aptible/terraform-provider-aptible/aptible 3226.310s
I'm going to stop adding bonus stuff to this PR now. It's already way bigger than it should have ever been.
For better or worse, I'm combining two features and a ton of style changes into one PR.
This adds support for Managed HTTPS endpoints and adds support for importing existing resources. I've been testing using the following config:
Quick import looks something like this (ids replaceable, of course):
Pairs with this PR: