search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

Update Terraform docs #56

Closed bayley-aptible closed 2 years ago

bayley-aptible commented 2 years ago

We don't document domain but use it, ran into this in https://aptible.zendesk.com/agent/tickets/40100

Used here: https://github.com/aptible/terraform-provider-aptible/blob/4092435629583997e851d1aa6df985b57befce1f/aptible/resource_endpoint.go#L151 App-Only: https://github.com/aptible/terraform-provider-aptible/blob/4092435629583997e851d1aa6df985b57befce1f/aptible/resource_endpoint.go#L163-L165

I think this is Managed TLS Hostname based on this but if this is used outside of Managed TLS then I have that wrong and this will need rewritten.

Unrelated, line 45, is elb still the correct default?

almathew commented 2 years ago

Unrelated, line 45, is elb still the correct default?

Good catch. Default is alb.

It looks like you saw this already, but if it helps to think about it this way, domain == user_domain in the API, we just switched the name here because user_domain felt confusing.