search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

feat: dropped ForceNew on apps and databases to allow handle changes (DO NOT MERGE) #63

Closed madhuravius closed 2 years ago

madhuravius commented 2 years ago

test criteria:

  1. create an app/db
  2. rename them
  3. ensure the renames are fine without bad things happening

sadly failing :(

https://app.shortcut.com/aptible/story/4705/renaming-an-app-or-database-via-terraform-should-not-destroy-the-app-or-database

Test results

  1. was able to plan and apply:
image image image
  1. was able to update
image image
  1. unfortunately - looks unchanged - @almathew. ticket may involve a little more work, looking into it now

Note lack of change:

image image
shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #4705: Renaming an app or database via Terraform should not destroy the app or database.

madhuravius commented 2 years ago

sanity check - i was using the local flavor:

image
madhuravius commented 2 years ago

This does function now with the addition of go-deploy changes along with other internal api changes:

image image