search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

feat: updated aptible app/db resources to support handle change #65

Closed madhuravius closed 2 years ago

madhuravius commented 2 years ago

DO NOT MERGE until this is merged: https://github.com/aptible/go-deploy/pull/47

A fuller format (including warning messages) was explored here - https://github.com/aptible/terraform-provider-aptible/pull/64 but this needs some additional cleanup/review. This PR does not contain the warning messages but does allow for updates. When releasing this we should avoid tagging until the warnings are in from the subsequent PR

The purpose of this PR is to allow handle changes on apps and databases.

To test:

  1. Create an app and/or database in terraform
  2. Change its handle and redeploy
  3. Do the same in no. 2 but change other aspects of the app and ensure multiple types of updates are supported

Proof of function:

  1. Created apps:

image

image image

  1. Updated handles

image

  1. Verified changed handles:

image image

shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #4705: Renaming an app or database via Terraform should not destroy the app or database.