aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

feat: added go-client wrapper for error reporting #69

Closed madhuravius closed 2 years ago

madhuravius commented 2 years ago

This should properly result in better error messages.


Before:

image

Wrapped errors with changes:

image

image

image

madhuravius commented 2 years ago

All of the changes look good. I did not pull down the repo to search for places that should be using the new client method that may have been missed.

I checked again on Tuesday, but I made sure to wrap every go-deploy client method (except 2 - GetApp and SetupClient) in the terraform provider with that code. I left those two out and planned on adding them in at some point later if needed/desired (both had additional wraps/guards within client calls compared to other methods and they did not cleanly bubble up the underlying client errors).