search

aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

[Endpoint] Add `domain` validation for managed endpoints #74

Closed Jrc356 closed 1 year ago

Jrc356 commented 2 years ago

According to the docs, if managed = true then domain must also be set but there is no validation for this. This PR adds that validationg

Jrc356 commented 1 year ago

@madhuravius and @joshraker will you guys be able to review this soon?

madhuravius commented 1 year ago

https://github.com/aptible/terraform-provider-aptible/pull/86 contained your commit.

Sorry for the delay - I had to add a unit test and I moved some of the client calls below the validations that could occur before the client calls immediately (and also worked a bit better in the context of the test suite)

edit - we have a testing suite that'll pick this up and we should release this in a patch early next week. sorry again for the lateness

madhuravius commented 1 year ago

Closing PR as above linked should contain the commit in this one. Thanks again for following up