aptible / terraform-provider-aptible

The official Terraform provider for Aptible Deploy
https://registry.terraform.io/providers/aptible/aptible/latest
10 stars 13 forks source link

fix: made env values sensitive so they're masked #95

Closed madhuravius closed 1 year ago

madhuravius commented 1 year ago

Proof of function with latest changes:

image

In some cases users will use sensitive values in the config thus printing on their print out, we want to validate that this does not reveal those values regardless of circumstance.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #10490: Mark app configuration as sensitive in Terraform.

madhuravius commented 1 year ago

The first change did not work:

image
madhuravius commented 1 year ago

I then RM'ed the state:

image image

and then tried to do a plan (causing a change)

image
jeremiahbowen commented 1 year ago

Thank you, @madhuravius!!! Now all our secrets are protected better! Feature request for 0.8. Maybe a way to differentiate secrets, like allowing APTIBLE_DOCKER_IMAGE to show in the diff. I suggest an additional field that you could merge when applying like secret_config or something.