search

aptiko / irma

Project management for IRMA—no code, mainly issues
0 stars 0 forks source link

Refactor pthelma.timeseries #16

Closed aptiko closed 5 years ago

aptiko commented 5 years ago

Blocks #15.

pthelma.timeseries is used by many other things. We are essentially replacing it with pandas, but pthelma.timeseries has a little additional functionality that needs to be taken care of.

aptiko commented 5 years ago

I created https://github.com/openmeteo/htimeseries. Essentially it is a refactoring of https://github.com/openmeteo/pd2hts, and it does things cleanly (pd2hts uses extra attributes on the pandas object, which is deprecated in later pandas versions).

The code is a bit messy as most of it is copied from pd2hts. But I think it's good for a start. @kickapoo I suggest a quick review just to get acquainted with the whole thing.

aptiko commented 5 years ago

Comment by @kickapoo: The documentation needs to say a bit more about the structure of the pandas object.