search

aptise / peter_sslers

or how i stopped worrying and learned to love the ssl certificate
Other
51 stars 0 forks source link

Send a distinct UserAgent with ACME HTTP requests #1

Closed cpu closed 6 years ago

cpu commented 6 years ago

The current ACME draft promoted sending a user-agent as a MUST (previously it was a SHOULD):

ACME clients MUST send a User-Agent header, in accordance with [RFC7231]. This header SHOULD include the name and version of the ACME software in addition to the name and version of the underlying HTTP client software.

It doesn't look like peter_sslers sends a custom User-Agent presently (though I admit I only skimmed the codebase quickly).

Would you please consider adding a custom User-Agent header to your project? It is extremely helpful for ACME server operators when diagnosing problems using server-side request logs.

Thanks!

jvanasco commented 6 years ago

Thanks for pointing this out. It currently does not and should. I'll handle this ASAP.

The lib/acme_v1.py file is just a fork off an old version of acme-tiny, which didn't not follow that practice back then (they do now).

jvanasco commented 6 years ago

Fixed https://github.com/aptise/peter_sslers/blob/5117f34659d35d53de813e217282edc5b8783ba7/peter_sslers/lib/acme_v1.py#L51-L60

cpu commented 6 years ago

@jvanasco Thanks for the quick turnaround! :racehorse: :trophy: