aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.56k stars 371 forks source link

Installer file path is wrong when mirroring the official Debian repository #1144

Open Sagi313 opened 1 year ago

Sagi313 commented 1 year ago

Detailed Description

I am mirroring "https://deb.debian.org/debian/" using Aptly. I am creating a mirror, creating a snapshot from that mirror, and then publishing that snapshot. I am using the -with-installer and -with-udebs flags.

I noticed that there is a file that is located on a different path in my mirror.

The "installer-amd64" dir is located in dists/bullseye/main/installer-amd64/ in the official Debian repository (http://ftp.debian.org/debian/dists/bullseye/main/installer-amd64/), and in my mirror of it, its getting located in dists/bullseye/contrib/installer-amd64/

Context

I am trying to create a custom Debian ISO using simple-cdd. simple-cdd is looking for the "installer-amd64" dir in the same path it has in the official Debian repository, and since it can't find it there, it fails.

Possible Implementation

The installer-amd64 should be located on the same path as in the official Debian repository.

Your Environment

Running on Debian 11 (bullseye), with aptly 1.4.0

reglim commented 1 year ago

Hi @Sagi313

I was just trying to recreate your bug, but I haven't been able to. Here's what I did:

aptly mirror create -architectures=amd64 -filter='Name (~ installer)'   -with-installer -with-udebs issue-1144-debian https://deb.debian.org/debian bullseye
aptly mirror update issue-1144-debian
aptly snapshot create issue-1144 from mirror issue-1144-debian
aptly publish snapshot issue-1144

Now, if I go to my publish folder I have this:

$ pwd
~/.aptly/public/dists/bullseye/main/installer-amd64/current/images
$ ls -la
Permissions Size User   Date Modified Name
drwxr-xr-x     - reglim  8 Mar 16:14  cdrom
drwxr-xr-x     - reglim  8 Mar 16:14  hd-media
.rw-r--r--  1.7k reglim  8 Mar 16:13  MANIFEST
.rw-r--r--   54k reglim  8 Mar 16:13  MANIFEST.udebs
.rw-r--r--   58k reglim  8 Mar 16:13  MD5SUMS
drwxr-xr-x     - reglim  8 Mar 16:14  netboot
.rw-r--r--   78k reglim  8 Mar 16:14  SHA256SUMS
.rw-r--r--   488 reglim  8 Mar 16:14  SHA256SUMS.gpg
.rw-r--r--  7.2k reglim  8 Mar 16:13  udeb.list

Which is what I would expect, but I'm also using aptly version 1.5.0.

Could you tell me if I did something wrong there or maybe try version 1.5 and see if that fixes the problem.