Fix the CodeCov Pipeline

reglim commented 1 year ago

The code coverage has had some issues in the past, which are addressed by this change.

Fixes: #1164

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

I changed the go test command to output to the GOCOVERDIR and upgraded the ci to go version 1.20. I also had to fix some issues that the linter detected, mainly replacing unused parameters with _.

Why this change is important?

The coverage should be accurate and it's not bad to test on the latest go version either.

Checklist

[ ] unit-test added (if change is algorithm)
[ ] functional test added/updated (if change is functional)
[ ] man page updated (if applicable)
[ ] bash completion updated (if applicable)
[ ] documentation updated
[x] author name in AUTHORS

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.96%. Comparing base (4bc2180) to head (c49b588).

:exclamation: Current head c49b588 differs from pull request most recent head c8ea704

Please upload reports for the commit c8ea704 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1165 +/- ## ========================================== - Coverage 74.81% 65.96% -8.85% ========================================== Files 144 143 -1 Lines 16248 16188 -60 ========================================== - Hits 12156 10679 -1477 - Misses 3152 4756 +1604 + Partials 940 753 -187 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neolynx commented 4 months ago

not quite sure what this fixes... suggest to close

aptly-dev / aptly