Print publish storage on graph

aptly-dev / aptly

aptly - Debian repository management tool

https://www.aptly.info/

MIT License

2.55k stars 369 forks source link

Print publish storage on graph #1168

Closed strike closed 1 year ago

strike commented 1 year ago

This helps visually distinguish between local publications and those on S3.

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

In PR, I changed publish name function to repo.GetPath() (source) which returns the same data (repo.Prefix, repo.Distribution), but also return storage if exists.

For visualization. In master: master In PR:

Checklist

[x] author name in AUTHORS

randombenj commented 1 year ago

Seems the ci is broken: https://github.com/aptly-dev/aptly/issues/1173

randombenj commented 1 year ago

@strike would you mind rebasing, the testsuite should be fixed :)

codecov[bot] commented 1 year ago

Codecov Report

Merging #1168 (4ae4422) into master (1df8cff) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   65.99%   65.99%           
=======================================
  Files         143      143           
  Lines       16196    16196           
=======================================
  Hits        10688    10688           
  Misses       4754     4754           
  Partials      754      754

Impacted Files	Coverage Δ
deb/graph.go	`0.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more