aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.55k stars 369 forks source link

Fix: Remove Batch from API options, set to true by default #1208

Closed reglim closed 10 months ago

reglim commented 11 months ago

It doesn't make sense to expose the Batch option, which, if false enables input from stdin for gpg passphrases, which blocks the api thread. Because of this, I removed the option, and set it to true by default.

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Why this change is important?

So the API can't get hung up because a user tries to sign a publish with a key that requires a passphrase he didn't provide in the request.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #1208 (8be8a47) into master (1df8cff) will decrease coverage by 0.03%. Report is 4 commits behind head on master. The diff coverage is 44.44%.

:exclamation: Current head 8be8a47 differs from pull request most recent head 519747a. Consider uploading reports for the commit 519747a to get more accurate results

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   65.99%   65.97%   -0.03%     
==========================================
  Files         143      143              
  Lines       16196    16192       -4     
==========================================
- Hits        10688    10682       -6     
- Misses       4754     4758       +4     
+ Partials      754      752       -2     
Files Changed Coverage Δ
api/publish.go 0.00% <0.00%> (ø)
deb/graph.go 0.00% <0.00%> (ø)
pgp/internal.go 57.86% <ø> (ø)
api/task.go 42.15% <100.00%> (ø)
deb/import.go 76.50% <100.00%> (+0.92%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more