aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.56k stars 374 forks source link

replace `golang.org/x/crypto/openpgp` with `github.com/ProtonMail/go-crypto/openpgp` #1228

Closed paulcacheux closed 10 months ago

paulcacheux commented 11 months ago

Fixes some TODOs in the code

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

This PR replaces golang.org/x/crypto/openpgp which is unsupported (issue) with github.com/ProtonMail/go-crypto/openpgp.

This has the added bonus of adding support for new pgp key types

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #1228 (6773724) into master (f1649a6) will increase coverage by 0.03%. The diff coverage is n/a.

:exclamation: Current head 6773724 differs from pull request most recent head f1c1891. Consider uploading reports for the commit f1c1891 to get more accurate results

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   74.85%   74.89%   +0.03%     
==========================================
  Files         143      143              
  Lines       16187    16179       -8     
==========================================
  Hits        12117    12117              
+ Misses       3134     3126       -8     
  Partials      936      936              
Files Coverage Δ
pgp/internal.go 56.97% <ø> (ø)
pgp/openpgp.go 61.48% <ø> (+3.15%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

paulcacheux commented 11 months ago

@randombenj sorry for the direct ping. Is this something you would be interested in ?

paulcacheux commented 11 months ago

Regarding the failing tests it seems the upstream repos were updated. Happy to rebase once main is green regarding those

paulcacheux commented 10 months ago

@randombenj maybe we can fix the CI first before merging. How can I help in that direction ?

randombenj commented 10 months ago

@paulcacheux as the tests don't fail because of your changes, I will merge this and then later on fix the tests on the main branch. Thanks for the contribution :tada: