search

aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.54k stars 369 forks source link

fixup: publish concurrency #1261

Closed runitonmetal closed 3 weeks ago

runitonmetal commented 3 months ago

See #1271

This MR addresses a concurrency issue with the api/publish endpoint, where concurrent PUTs typically fail. The MR in it self is not pretty, so consider this initial state of the MR a starting point of discussion. The commits are intentionally separated in order to make it as easy as possible to observe the failing test (and test it against other likely better code changes).

runitonmetal commented 3 months ago

I'm happy to fix this MR up if it's of interest. Beyond a better code change I suggest the commits are squashed ahead of merge, they are separated for the convenience of any reviewer.

neolynx commented 3 months ago

thanks a lot, looks interesting ! will look into it...

neolynx commented 2 months ago

could you rebase on master ? then the test should run and produce some errors, as you can see here: https://github.com/aptly-dev/aptly/pull/1271

thanks !

neolynx commented 2 months ago

Rebased on master and fixed comlipation/lint: https://github.com/aptly-dev/aptly/pull/1271

Could you check comments there, 1 test is failing, might be expected behavior now...