search

aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.56k stars 374 forks source link

github: add arm builds #1286

Closed neolynx closed 2 weeks ago

neolynx commented 5 months ago

Fixes #1199, #960, #1108

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

TODO

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (9591548) to head (88b9513). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
s3/public.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1286 +/- ## ========================================== - Coverage 74.51% 74.51% -0.01% ========================================== Files 150 150 Lines 16994 16997 +3 ========================================== + Hits 12663 12665 +2 - Misses 3322 3323 +1 Partials 1009 1009 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neolynx commented 5 months ago

goxc does not seem to build for arm64:

ls -l build/
total 168736
-rw-r--r-- 1 root root 17893770 Apr 21 17:19 aptly_1.5.0+113+g6619f929_amd64.deb
-rw-r--r-- 1 root root 16546322 Apr 21 17:19 aptly_1.5.0+113+g6619f929_armhf.deb
-rw-r--r-- 1 root root 18089983 Apr 21 17:19 aptly_1.5.0+113+g6619f929_darwin_amd64.zip
-rw-r--r-- 1 root root 17016974 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_386.zip
-rw-r--r-- 1 root root 17883988 Apr 21 17:19 aptly_1.5.0+113+g6619f929_freebsd_amd64.zip
-rw-r--r-- 1 root root 17057506 Apr 21 17:19 aptly_1.5.0+113+g6619f929_i386.deb
-rw-r--r-- 1 root root 17049372 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_386.tar.gz
-rw-r--r-- 1 root root 17887161 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_amd64.tar.gz
-rw-r--r-- 1 root root 16539569 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm.tar.gz
-rw-r--r-- 1 root root 16802958 Apr 21 17:19 aptly_1.5.0+113+g6619f929_linux_arm64.tar.gz

-> depends on #1287

neolynx commented 2 weeks ago

replaced by https://github.com/aptly-dev/aptly/pull/1339