search

aptly-dev / aptly

aptly - Debian repository management tool
https://www.aptly.info/
MIT License
2.58k stars 376 forks source link

Azure Storage Blob SDK for Go DEPRECATED #1290

Open scentoni opened 6 months ago

scentoni commented 6 months ago

The library https://github.com/Azure/azure-storage-blob-go/ that aptly uses to deploy packages to Azure is deprecated and will be retired 2024-09-13. As described there, it should be replaced with https://github.com/Azure/azure-sdk-for-go before that date.

Comparing the old azblob SDK documentation https://pkg.go.dev/github.com/Azure/azure-storage-blob-go/azblob and the new azblob SDK documentation https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob, it does not appear to be a drop-in replacement.

SingulariteeSplunk commented 6 months ago

@neolynx , @chuan , @randombenj , @lbolla , @andrewshadura - Apologies for all the tags, but wasn't sure who would be most appropriate. It looks like we have an incoming breaking change soon for the newly added Azure support. Does anyone have cycles to take a look?

neolynx commented 6 months ago

Thanks for reporting !!

as I don't really have azure storage access, I would need some help with that..

would you be able to prepare a pull request ?

plane-wave commented 3 weeks ago

@neolynx Hi there! Do you still need access to an Azure storage instance to test this? Or I read elsewhere that you would like to stay on a particular Go version.

neolynx commented 2 weeks ago

the go version has been updated to 1.22.7 ! would that be suitable for the new Azure SDK ?

yes, if you could help with testing Azure (i.e. have a test account) that would be great. I had a free tier, but it expired..

neolynx commented 2 weeks ago

also, aptly uses https://github.com/potatoqualitee/azuright 1.1 for testing azure. but there seems to be no newer version. it would be greate somehow if the new sdk could be emulated for testing.

do you think this is already possible with 1.1 ?

neolynx commented 2 weeks ago

I migrated to the new azure sdk, kinda, it compiles but unit tests now fail (on azurite)...

neolynx commented 1 week ago

test are passing now ! azurite was used for testing

@plane-wave would you be able to compile and test the branch with a real Azure ? especially with using a publish prefix, not sure it is handled correctly everywhere...

@scentoni, @SingulariteeSplunk would you be able to test as well ?

andrewshadura commented 1 week ago

@em-, maybe you can test this on real Azure?

neolynx commented 1 week ago

branch is: fix/azure-sdk-migration

It would be great to test with big files, symlinks (link from pool, acquireByHash), removing files... All of with with and without prefix, and once also with having the whole pool on azure, which was a new feature added and I am not sure the tests fully cover this...

neolynx commented 1 week ago

switched to new sdk, please try latest CI builds !