search

aptly-io / pwsync

Synchronize between password database (Keepass and Bitwarden)
GNU General Public License v3.0
7 stars 1 forks source link

3 bitwarden tests fail #18

Open aptly-io opened 1 week ago

aptly-io commented 1 week ago

After upgrading to bitwarden-client version 2024.11.0 3 tests are failing:

FAILED tests/test_bwc.py::test_create_many_params - assert 0 == 1
FAILED tests/test_bwc.py::test_update_remove_organization - subprocess.CalledProcessError: Command '['bw', '--raw', 'get', 'item', 'eb03b758-9834-4b36-bce9-b23001453089']' returned non-zero exit status 1.
FAILED tests/test_bwc.py::test_update_add_collection - subprocess.CalledProcessError: Command '['bw', '--raw', 'get', 'item', '61068808-bcda-4963-a5db-b2300145c334']' returned non-zero exit status 1.

It has to do with the ORGANIZATION_NAME in bwc.create(PwsItem(TITLE, NAME, SECRET, None, None, None, None, False, ORGANIZATION_NAME)). When replacing this with None, both test_create_many_params (and disabling the assert for organization) and test_update_add_collection pass.

Since I do not use organizations inside Keepass, it is not really a problem when using pwsync to sync from keepass to bitwarden.

aptly-io commented 1 week ago

Part of the failure is due to mixing up folders and organizations in the test: an organization does not support folders, only collections. https://community.bitwarden.com/t/organisation-folders-show-up-when-they-should-not-in-the-web-or-desktop-app/47544/2

aptly-io commented 1 week ago

Asked in https://github.com/bitwarden/clients/issues/12159