search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.16k stars 3.63k forks source link

[Feature Request] Avoid using unicode in aptos-core, to reduce chances of bugs in IDEs #12671

Open brmataptos opened 6 months ago

brmataptos commented 6 months ago

🚀 Feature Request

A few Rust IDE combinations seem to have issues with Unicode, notably Emacs with rust-analyzer. There was a recent fix to rust-analyzer, so maybe the "master" branch of rust-analyzer will solve the problem for me, but I wonder how many outside people would give up on our project if their editor froze as often as mine does.

Do we really need to use a UTF8 character to represent "(C)" in (many of) our source files? That's the only non-ASCII character in almost all files (2482 out of 3090 files). Just 10 files use non-ASCII characters for other things, mostly for ASCII art, ironically.

We should minimize use of non-ASCII in our source code.

brmataptos commented 6 months ago

Note that Peter Nadimi has signed off on changing from © to (c) in our copyright notices.