Open brmataptos opened 7 months ago
@rahxephon89 @vineethk please review.
@brmataptos Given that M
, A
, B
, K
all have specific test folders associated with them, what do you think about the alternative: for these named addresses, we only add them through test configs for those specific folders.
It is really easy to forget that these are supposed to be standard "test" addresses.
Another option is to use different unique names (aptos_testing_M
, etc) that are harder to inadvertently use in our tests, and then change the existing tests to use these names instead.
Note that named addresses in tests are pretty uncommon.
🐛 Bug
v1's move_check_testsuite.rs defines a set of named addresses for all tests. To port V1 tests we will need some of these, but perhaps adding them all could result in conflicts with other named addresses in V2 tests.
It appears that -
std
is used in various testsaptos_std
we need for tests of certain warning suppressions in aptos libs.M
being defined.A
andB
being defined to the same value.Async
A
,B
, andK
.But
A
not being defined (but it is, so the test does not fail as it should).I think that we should: