search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
6.04k stars 3.61k forks source link

[Bug] ValidatorConfig inconsistency between Move type, `aptos` crate and `types` crate #13152

Closed so-schen closed 2 weeks ago

so-schen commented 4 months ago

🐛 Bug

Regarding consensus_public_key of ValidatorConfig resource defined in Move contract is vector, while in Rust in types crate, it has type bls12381::PublicKey in aptos crate, it as Vec.

To reproduce

If before calling rotate consensus key, we try to read ValidatorConfig on-chain, it will fail to deserailze because it is initialized as empty vector, while we try to deserialize into bls12381::PublicKey

Expected Behavior

should update ValidatorConfig in types consistent with Move type, and aptos cli crate can reuse same type to avoid confusion

System information

version v.1.10, should also exist in latest codes

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.