[CI/CD] Remove rust-unit-tests job from PR triggers.

JoshLind commented 2 weeks ago

Description

This PR prevents the rust-unit-tests job from triggering on every PR. Running all rust unit tests is no longer required because it has been replaced by targeted unit tests instead.

Note:

Going forward, the rust-unit-tests job will only trigger: (i) using workflow dispatch; (ii) on a relevant branch push; or (iii) if the CICD:run-all-unit-tests label is added to a PR. This is useful for us to be able to monitor the accuracy of the targeted unit tests job while it bakes, and help to detect any unwanted breakages.

Testing Plan

Manual verification and existing test infrastructure.

trunk-io[bot] commented 2 weeks ago

⏱️ 5h 12m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24567725832) | 57m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217605) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24567725832) | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533208437) | 53m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256853/job/24523413666) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533208437) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533218640) | 25m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256924/job/24523426216) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533218640) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8931339514/job/24533218726) | 24m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339514/job/24533218726) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217225) | 22m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957113/job/24522460431) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176737/job/24523171129) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256853/job/24523423569) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217225) | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8931339534/job/24533207028) | 19m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339534/job/24533207028) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528311) | 18m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528311) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533222958) | 17m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927956996/job/24522467748) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176536/job/24523171773) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256874/job/24523427662) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533222958) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528449) | 15m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528449) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339532/job/24533207633) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957100/job/24522447174) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176731/job/24523153394) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256857/job/24523412279) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339532/job/24533207633) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217817) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957113/job/24522460943) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176737/job/24523171583) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256853/job/24523423919) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217817) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217409) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957113/job/24522460674) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176737/job/24523171375) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256853/job/24523423757) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217409) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533213381) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256924/job/24523419507) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533213381) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8931339523/job/24533207025) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957105/job/24522446655) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176730/job/24523152871) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256876/job/24523411576) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339523/job/24533207025) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533527995) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533527995) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339516/job/24533207576) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339516/job/24533207576) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217995) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533217995) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8931339518/job/24533207021) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957120/job/24522446603) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176741/job/24523152852) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256883/job/24523411633) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339518/job/24533207021) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528163) | 50s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528163) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533212575) | 45s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927956996/job/24522452314) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176536/job/24523159732) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256874/job/24523419140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533212575) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533207870) | 42s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957113/job/24522447413) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176737/job/24523153637) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256853/job/24523412536) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339522/job/24533207870) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533213219) | 23s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256924/job/24523419684) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533213219) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339562/job/24533207176) | 15s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957001/job/24522446037) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176543/job/24523152119) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256877/job/24523411867) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339562/job/24533207176) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8931339514/job/24533207544) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339514/job/24533207544) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339567/job/24533207769) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957009/job/24522446569) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176539/job/24523152525) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256873/job/24523412449) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339567/job/24533207769) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339566/job/24533207314) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927957002/job/24522445980) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176534/job/24523152138) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256862/job/24523411748) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339566/job/24533207314) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533208028) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8927956996/job/24522446392) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928176536/job/24523152647) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256874/job/24523412799) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339563/job/24533208028) | | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528621) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533528621) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533212980) | 5s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256924/job/24523419854) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533212980) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533208377) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8928256924/job/24523413270) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8931339636/job/24533208377) |

🚨 5 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
forge-compat-test / forge	18m	14m
rust-build-cached-packages	4m	5m
windows-build	19m	36m
rust-move-tests	4m	9m
rust-targeted-unit-tests	3m	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `58a19715cbe9a5067b0fa0151d129f73929e8a23`

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `58a19715cbe9a5067b0fa0151d129f73929e8a23`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `58a19715cbe9a5067b0fa0151d129f73929e8a23`

two traffics test: inner traffic : committed: 7856 txn/s, latency: 4990 ms, (p50: 4800 ms, p90: 5800 ms, p99: 11700 ms), latency samples: 3394180
two traffics test : committed: 100 txn/s, latency: 1902 ms, (p50: 1900 ms, p90: 2100 ms, p99: 5400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.211, avg: 0.205", "QsPosToProposal: max: 0.268, avg: 0.229", "ConsensusProposalToOrdered: max: 0.445, avg: 0.412", "ConsensusOrderedToCommit: max: 0.422, avg: 0.396", "ConsensusProposalToCommit: max: 0.828, avg: 0.808"]
Max round gap was 1 [limit 4] at version 1740039. Max no progress secs was 4.79396 [limit 15] at version 1740039.
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `58a19715cbe9a5067b0fa0151d129f73929e8a23`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 58a19715cbe9a5067b0fa0151d129f73929e8a23 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5459 txn/s, latency: 5555 ms, (p50: 4900 ms, p90: 9600 ms, p99: 11300 ms), latency samples: 234760
2. Upgrading first Validator to new version: 58a19715cbe9a5067b0fa0151d129f73929e8a23
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1670 txn/s, latency: 17127 ms, (p50: 19300 ms, p90: 22400 ms, p99: 22800 ms), latency samples: 86840
3. Upgrading rest of first batch to new version: 58a19715cbe9a5067b0fa0151d129f73929e8a23
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1237 txn/s, latency: 20792 ms, (p50: 25100 ms, p90: 29800 ms, p99: 30300 ms), latency samples: 73000
4. upgrading second batch to new version: 58a19715cbe9a5067b0fa0151d129f73929e8a23
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3523 txn/s, latency: 8858 ms, (p50: 9600 ms, p90: 12600 ms, p99: 13900 ms), latency samples: 144460
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 58a19715cbe9a5067b0fa0151d129f73929e8a23 passed
Test Ok

aptos-labs / aptos-core