[not for review] Igor/test after fa with concurrent

igor-aptos commented 2 weeks ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 7h 46m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8942079754/job/24563878065) | 3h 7m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8929599827/job/24527786157) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8929599834/job/24527786341) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8929599825/job/24527789167) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8941991933/job/24563598198) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942079754/job/24563878065) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563891087) | 1h 49m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8929599781/job/24527790843) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991910/job/24563607163) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563891087) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8942079730/job/24563875729) | 39m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599812/job/24527775433) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991918/job/24563588670) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079730/job/24563875729) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563893504) | 35m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599885/job/24527793341) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991865/job/24563603574) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563893504) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8942079734/job/24563876593) | 27m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8929599817/job/24527776651) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991924/job/24563588759) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942079734/job/24563876593) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563886070) | 21m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599885/job/24527785727) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991865/job/24563597040) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563886070) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563890453) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599781/job/24527789757) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8941991910/job/24563606890) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563890453) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563883108) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599822/job/24527794615) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991840/job/24563608083) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563883108) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8942079738/job/24563863192) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599780/job/24527772635) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599793/job/24527772430) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599789/job/24527772661) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991916/job/24563588012) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079738/job/24563863192) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563890051) | 6m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599781/job/24527789979) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991910/job/24563606657) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563890051) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8942079727/job/24563862978) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599805/job/24527773383) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599809/job/24527773334) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599808/job/24527773920) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991920/job/24563588004) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079727/job/24563862978) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942079754/job/24563863728) | 55s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599834/job/24527775140) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599825/job/24527775315) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599827/job/24527775134) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991933/job/24563588465) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079754/job/24563863728) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563886309) | 38s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599885/job/24527785502) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991865/job/24563596436) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563886309) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563869154) | 37s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599822/job/24527785132) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991840/job/24563593532) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563869154) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563876895) | 36s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599781/job/24527776876) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991910/job/24563588809) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079728/job/24563876895) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942079370/job/24563861925) | 19s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599723/job/24527773904) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599810/job/24527774141) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599824/job/24527773710) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991839/job/24563587074) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079370/job/24563861925) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942079377/job/24563861920) | 16s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599696/job/24527772032) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599829/job/24527773617) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599826/job/24527773947) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991838/job/24563587095) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079377/job/24563861920) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563878772) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599885/job/24527777116) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991865/job/24563588613) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563878772) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563885815) | 9s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599885/job/24527785223) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991865/job/24563596794) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079445/job/24563885815) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942079373/job/24563862337) | 8s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8929599694/job/24527773719) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599807/job/24527778648) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991832/job/24563587488) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079373/job/24563862337) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563862373) | 6s | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8929599697/job/24527774330) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8929599822/job/24527778882) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8941991840/job/24563587402) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942079372/job/24563862373) |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
rust-targeted-unit-tests	52m	15m
framework-upgrade-determinator	11m	4m
execution-performance / single-node-performance	35m	25m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 30.00000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 57.5%. Comparing base (bd2bd6a) to head (976d157).

Files	Patch %	Lines
...rk/src/natives/aggregator_natives/aggregator_v2.rs	4.5%	42 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## igor/fa_after_migration_complete #13180 +/- ## =================================================================== - Coverage 57.6% 57.5% -0.1% =================================================================== Files 834 834 Lines 198265 198319 +54 =================================================================== - Hits 114209 114208 -1 - Misses 84056 84111 +55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aptos-labs / aptos-core