search

aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

[Bug]Unknown manifest field "upgrade_policy" #13182

Open brmataptos opened 2 weeks ago

brmataptos commented 2 weeks ago

🐛 Bug

The field "upgrade_policy" appears in a number of Aptos Move examples and e2e-move tests, but the manifest_parser doesn't know about it. It shows up as a warning when processing the Move.toml file (try --nocapture when running aptos-move-examples tests). As this field is documented (see https://aptos.dev/move/book/package-upgrades/#how-it-works) it should be supported in third_party/move/tools/move-package/src/source_package/manifest_parser.rs.

Here are the tests including it:

./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_init_module_failed/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_init_module_second_attempt/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial_arbitrary/Move.toml:upgrade_policy = "arbitrary"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial_immutable/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_large/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_large_upgrade/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_other_name/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_compat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_incompat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_incompat_arbitrary/Move.toml:upgrade_policy = "arbitrary"
./aptos-move/e2e-move-tests/src/tests/error_map.data/pack/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_initial/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_initial_immutable/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_other_name/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_upgrade_compat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_upgrade_incompat/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/cli_args/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/dao/nft_dao/Move.toml:upgrade_policy = "immutable"
./aptos-move/move-examples/large_packages/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/large_packages/large_package_example/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/package_manager/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/resource_account/Move.toml:upgrade_policy = "compatible"
wrwg commented 2 weeks ago

Because third-party needed to be agnostic until recently, this must have been kept out of it as it is aptos specific. Moving forward we replace the package system so I don't think this bug should be kept.

brmataptos commented 2 weeks ago

Are you saying that you have expect that it will be fixed, so this bug should be closed?