aptos-labs / aptos-core

Aptos is a layer 1 blockchain built to support the widespread use of blockchain through better technology and user experience.
https://aptosfoundation.org
Other
5.85k stars 3.54k forks source link

[cli] Bump to 3.3.0 #13187

Closed vineethk closed 2 weeks ago

vineethk commented 2 weeks ago

Description

Version bump ahead of release. Please note that this PR will not be merged in until all the release-blocking PRs land on main (which should be fairly soon). Please do not auto-merge.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

n/a

Key Areas to Review

Is the version bump acceptable or do we bump it to 4.0.0? There was an unreleased breaking change that I am not sure whether it qualifies to move up major version (or if the minor version bump suffices).

Checklist

trunk-io[bot] commented 2 weeks ago
⏱️ 5h 34m total CI duration on this PR | Job | Cumulative Duration | Recent Runs | |---|---|---| | [forge-framework-upgrade-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898252) | 1h 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898252)  | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8952875033/job/24590748154) | 42m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875033/job/24590748154)  | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754594) | 38m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754594)  | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754650) | 30m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8940704401/job/24559402258) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793952/job/24559716279) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8952864746/job/24590728499) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754650)  | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754533) | 24m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8940704401/job/24559401362) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793952/job/24559714890) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8952864746/job/24590728451) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754533)  | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8952875037/job/24590751339) | 24m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875037/job/24590751339)  | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8952875041/job/24590751538) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704404/job/24559384398) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793935/job/24559688328) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8952864745/job/24590725350) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875041/job/24590751538)  | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898195) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898195)  | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590752015) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590752015)  | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898127) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590898127)  | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590897921) | 9m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590897921)  | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590752446) | 9m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704323/job/24559411973) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793936/job/24559717874) [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8952864714/job/24590730064) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590752446)  | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754706) | 8m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754706)  | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754455) | 7m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704401/job/24559401088) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793952/job/24559715228) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864746/job/24590728559) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590754455)  | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8952875034/job/24590748199) | 5m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704409/job/24559383128) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793953/job/24559686945) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864749/job/24590725201) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875034/job/24590748199)  | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750802) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750802)  | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875043/job/24590748304) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875043/job/24590748304)  | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8952875038/job/24590748147) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704411/job/24559383288) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793957/job/24559687115) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864743/job/24590725176) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875038/job/24590748147)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590750708) | 52s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704323/job/24559393554) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793936/job/24559700487) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864714/job/24590727056) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590750708)  | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590897982) | 51s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590897982)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590751505) | 47s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704401/job/24559385328) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793952/job/24559703122) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864746/job/24590725310) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875045/job/24590751505)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875047/job/24590748307) | 17s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704328/job/24559384009) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793932/job/24559688566) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864711/job/24590725157) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875047/job/24590748307)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875048/job/24590748194) | 16s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704322/job/24559382975) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793933/job/24559686971) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864712/job/24590725093) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875048/job/24590748194)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590748546) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704323/job/24559384400) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793936/job/24559688921) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864714/job/24590725199) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875044/job/24590748546)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875046/job/24590748152) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940704324/job/24559382914) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8940793926/job/24559687809) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952864710/job/24590725106) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875046/job/24590748152)  | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750625) | 12s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750625)  | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8952875037/job/24590748267) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875037/job/24590748267)  | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750713) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590750713)  | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590748377) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8952875058/job/24590748377)  |

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 10m 6m +73%
rust-build-cached-packages 8m 5m +68%
cli-e2e-tests / run-cli-tests 9m 7m +37%
windows-build 42m 35m +22%

settingsfeedbackdocs ⋅ learn more about trunk.io

github-actions[bot] commented 2 weeks ago

Forge is running suite realistic_env_max_load on 5ae1a127f4044bea42c734c2b93b8d7339e55213

github-actions[bot] commented 2 weeks ago

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213

github-actions[bot] commented 2 weeks ago

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6245 txn/s, latency: 5052 ms, (p50: 4800 ms, p90: 9300 ms, p99: 10500 ms), latency samples: 237320
2. Upgrading first Validator to new version: 5ae1a127f4044bea42c734c2b93b8d7339e55213
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1707 txn/s, latency: 16240 ms, (p50: 19000 ms, p90: 23800 ms, p99: 25000 ms), latency samples: 92180
3. Upgrading rest of first batch to new version: 5ae1a127f4044bea42c734c2b93b8d7339e55213
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1344 txn/s, latency: 17661 ms, (p50: 19300 ms, p90: 24200 ms, p99: 30600 ms), latency samples: 80680
4. upgrading second batch to new version: 5ae1a127f4044bea42c734c2b93b8d7339e55213
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2837 txn/s, latency: 11174 ms, (p50: 10000 ms, p90: 15300 ms, p99: 16800 ms), latency samples: 110660
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213 passed
Test Ok
github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite realistic_env_max_load success on 5ae1a127f4044bea42c734c2b93b8d7339e55213

two traffics test: inner traffic : committed: 7062 txn/s, latency: 5522 ms, (p50: 5400 ms, p90: 6900 ms, p99: 13600 ms), latency samples: 3065320
two traffics test : committed: 100 txn/s, latency: 1868 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2500 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.201", "QsPosToProposal: max: 0.384, avg: 0.303", "ConsensusProposalToOrdered: max: 0.503, avg: 0.458", "ConsensusOrderedToCommit: max: 0.383, avg: 0.365", "ConsensusProposalToCommit: max: 0.864, avg: 0.823"]
Max round gap was 1 [limit 4] at version 1432275. Max no progress secs was 4.251217 [limit 15] at version 1432275.
Test Ok
github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213 (PR)
Upgrade the nodes to version: 5ae1a127f4044bea42c734c2b93b8d7339e55213
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1276 txn/s, submitted: 1279 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2491 ms, (p50: 2100 ms, p90: 4200 ms, p99: 5400 ms), latency samples: 108500
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1267 txn/s, submitted: 1269 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2511 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6800 ms), latency samples: 112780
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 5ae1a127f4044bea42c734c2b93b8d7339e55213 passed
Upgrade the remaining nodes to version: 5ae1a127f4044bea42c734c2b93b8d7339e55213
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 973 txn/s, submitted: 976 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 3057 ms, (p50: 2400 ms, p90: 5400 ms, p99: 6900 ms), latency samples: 87600
Test Ok