inlining metadata, to reduce 1 resource read

igor-aptos commented 2 weeks ago

Description

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

trunk-io[bot] commented 2 weeks ago

⏱️ 3h 47m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8942238707/job/24564397453) | 1h 47m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238772/job/24564396255) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238739/job/24564396580) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238707/job/24564397453) | | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398506) | 52m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398506) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8942238718/job/24564386099) | 16m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238718/job/24564386099) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564401549) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564401549) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8942238755/job/24564388712) | 11m | [⬜](https://github.com/aptos-labs/aptos-core/actions/runs/8942238699/job/24564385899) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238755/job/24564388712) | | [framework-upgrade-determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564394099) | 10m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564394099) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398319) | 6m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398319) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564404514) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564404514) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8942238696/job/24564384491) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238753/job/24564385241) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238720/job/24564384803) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238696/job/24564384491) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398075) | 2m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564398075) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8942238749/job/24564385122) | 1m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238684/job/24564384226) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238719/job/24564384928) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238749/job/24564385122) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942238707/job/24564385541) | 31s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238772/job/24564386323) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238739/job/24564386129) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238707/job/24564385541) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564393180) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564393180) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564393537) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564393537) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942238632/job/24564384044) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238630/job/24564383724) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238635/job/24564383849) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238632/job/24564384044) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564387495) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238762/job/24564387495) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942238639/job/24564383701) | 8s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238623/job/24564384096) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238625/job/24564384062) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238639/job/24564383701) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564393790) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564393790) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942238627/job/24564386576) | 4s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238627/job/24564386576) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564386702) | 3s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238633/job/24564386702) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564387617) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942238697/job/24564387617) |

🚨 3 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg
rust-targeted-unit-tests	52m	15m
framework-upgrade-determinator	10m	4m
execution-performance / single-node-performance	36m	25m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.5%. Comparing base (976d157) to head (41baea4).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## igor/test_after_fa_with_concurrent #13189 +/- ## =================================================================== Coverage 57.5% 57.5% =================================================================== Files 834 834 Lines 198319 198319 =================================================================== + Hits 114208 114224 +16 + Misses 84111 84095 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aptos-labs / aptos-core