Reverting dispatchable on 1.12

runtian-zhou commented 2 weeks ago

Description

Reverting #12635 on 1.12 branch.

trunk-io[bot] commented 2 weeks ago

⏱️ 4h 59m total CI duration on this PR

| Job | Cumulative Duration | Recent Runs | |---|---|---| | [rust-targeted-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626334) | 47m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821695/job/24566208330) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626334) | | [windows-build](https://github.com/aptos-labs/aptos-core/actions/runs/8945881252/job/24575616115) | 39m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881252/job/24575616115) | | [rust-smoke-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626109) | 34m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626109) | | [rust-unit-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626979) | 29m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626979) | | [execution-performance / single-node-performance](https://github.com/aptos-labs/aptos-core/actions/runs/8945881257/job/24575623289) | 25m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881257/job/24575623289) | | [rust-move-unit-coverage](https://github.com/aptos-labs/aptos-core/actions/runs/8942821737/job/24566199291) | 19m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821737/job/24566199291) | | [rust-move-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881232/job/24575616451) | 18m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821682/job/24566199269) [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8945881232/job/24575616451) | | [forge-e2e-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890636) | 14m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890636) | | [forge-compat-test / forge](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890877) | 13m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890877) | | [rust-images / rust-all](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575624134) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575624134) | | [rust-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575625438) | 12m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821695/job/24566207752) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575625438) | | [run-tests-main-branch](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575634005) | 10m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821583/job/24566214335) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575634005) | | [cli-e2e-tests / run-cli-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890749) | 9m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890749) | | [rust-build-cached-packages](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626783) | 4m | [🟥](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575626783) | | [check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881230/job/24575616248) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881230/job/24575616248) | | [general-lints](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575625850) | 4m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821695/job/24566207552) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575625850) | | [check-dynamic-deps](https://github.com/aptos-labs/aptos-core/actions/runs/8945881249/job/24575615929) | 3m | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821688/job/24566198510) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881249/job/24575615929) | | [node-api-compatibility-tests / node-api-compatibility-tests](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890975) | 50s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575890975) | | [semgrep/ci](https://github.com/aptos-labs/aptos-core/actions/runs/8945881242/job/24575615933) | 43s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821710/job/24566198731) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881242/job/24575615933) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575623383) | 29s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821583/job/24566205131) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575623383) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575616813) | 21s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821695/job/24566199623) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881325/job/24575616813) | | [file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575620184) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575620184) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881256/job/24575616154) | 13s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821592/job/24566198306) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881256/job/24575616154) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575616546) | 11s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821583/job/24566199067) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881226/job/24575616546) | | [execution-performance / file_change_determinator](https://github.com/aptos-labs/aptos-core/actions/runs/8945881257/job/24575616354) | 10s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881257/job/24575616354) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881228/job/24575615863) | 7s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821609/job/24566198492) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881228/job/24575615863) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881246/job/24575616460) | 6s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8942821613/job/24566199037) [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881246/job/24575616460) | | [permission-check](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575616642) | 2s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575616642) | | [determine-docker-build-metadata](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575620004) | 1s | [🟩](https://github.com/aptos-labs/aptos-core/actions/runs/8945881245/job/24575620004) |

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
cli-e2e-tests / run-cli-tests	9m	7m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 53.33333% with 42 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (aptos-release-v1.12@a1e2112). Click here to learn what that means.

Files	Patch %	Lines
aptos-move/aptos-vm/src/aptos_vm.rs	0.0%	22 Missing :warning:
...hird_party/move/move-vm/runtime/src/interpreter.rs	77.1%	13 Missing :warning:
aptos-move/aptos-vm/src/transaction_validation.rs	0.0%	5 Missing :warning:
...ptos-vm/src/verifier/transaction_arg_validation.rs	0.0%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## aptos-release-v1.12 #13190 +/- ## ====================================================== Coverage ? 62.1% ====================================================== Files ? 825 Lines ? 182451 Branches ? 0 ====================================================== Hits ? 113317 Misses ? 69134 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Forge is running suite `realistic_env_max_load` on `fbf25a39787858a72cd81f74c2334287b6e79b7f`

github-actions[bot] commented 2 weeks ago

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `fbf25a39787858a72cd81f74c2334287b6e79b7f`

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `compat` success on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `fbf25a39787858a72cd81f74c2334287b6e79b7f`

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> fbf25a39787858a72cd81f74c2334287b6e79b7f (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6167 txn/s, latency: 5238 ms, (p50: 5100 ms, p90: 8900 ms, p99: 9600 ms), latency samples: 222020
2. Upgrading first Validator to new version: fbf25a39787858a72cd81f74c2334287b6e79b7f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1640 txn/s, latency: 17753 ms, (p50: 19100 ms, p90: 24600 ms, p99: 24900 ms), latency samples: 88600
3. Upgrading rest of first batch to new version: fbf25a39787858a72cd81f74c2334287b6e79b7f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1753 txn/s, latency: 16497 ms, (p50: 18100 ms, p90: 24200 ms, p99: 24700 ms), latency samples: 89440
4. upgrading second batch to new version: fbf25a39787858a72cd81f74c2334287b6e79b7f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3518 txn/s, latency: 8949 ms, (p50: 9500 ms, p90: 13000 ms, p99: 13500 ms), latency samples: 144260
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> fbf25a39787858a72cd81f74c2334287b6e79b7f passed
Test Ok

github-actions[bot] commented 2 weeks ago

:white_check_mark: Forge suite `realistic_env_max_load` success on `fbf25a39787858a72cd81f74c2334287b6e79b7f`

two traffics test: inner traffic : committed: 7572 txn/s, latency: 5189 ms, (p50: 5100 ms, p90: 6000 ms, p99: 12300 ms), latency samples: 3263860
two traffics test : committed: 100 txn/s, latency: 1900 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 1880
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.211, avg: 0.202", "QsPosToProposal: max: 0.307, avg: 0.245", "ConsensusProposalToOrdered: max: 0.492, avg: 0.445", "ConsensusOrderedToCommit: max: 0.428, avg: 0.382", "ConsensusProposalToCommit: max: 0.888, avg: 0.827"]
Max round gap was 1 [limit 4] at version 1615923. Max no progress secs was 4.624572 [limit 15] at version 1615923.
Test Ok

aptos-labs / aptos-core